-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put all models in the constants #9170
Conversation
An alternative is to remove all content, but the previous state where one variable as some keys but the others not leads to failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @sgugger!
Yes, we really need to remove all of this @LysandreJik @thomwolf |
We do, but right now we still use them in the tests |
It was a bit confusing to me which to add in the constants and which not.. 😅 |
@sgugger one more small fix you can add is in tapas.rst under "Usage: inference", there should be one more space: (Sorry, if I see more things I make a new PR myself :p) |
Pushing your fix on master directly Niels |
* Put all models in the constants * Add Google AI mention in the main README
What does this PR do?
It was impossible to use all pretrained checkpoints in the tapas tokenzier file because they were not in the constants of the file. This PR fixes that.